Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Helm] support task type filter #15179

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

The following configuration will take effect when deployed via Helm. The result is as shown in the figure

api:
  taskTypeFilter:
    enabled: true
    task:
        universal:
          - 'SQL'
          - 'HTTP'
        cloud:
          - 'K8S'
        logic:
          - 'SUB_PROCESS'
          - 'DEPENDENT'
          - 'CONDITIONS'
          - 'SWITCH'
          - 'DYNAMIC'
        dataIntegration: []
        dataQuality: []
        machineLearning: []
        other: []

image

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b4edb3) 38.24% compared to head (4c16d6a) 38.24%.

❗ Current head 4c16d6a differs from pull request most recent head 16b2b7e. Consider uploading reports for the commit 16b2b7e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15179      +/-   ##
============================================
- Coverage     38.24%   38.24%   -0.01%     
- Complexity     4696     4699       +3     
============================================
  Files          1285     1285              
  Lines         45471    45471              
  Branches       4952     4950       -2     
============================================
- Hits          17391    17390       -1     
  Misses        26188    26188              
- Partials       1892     1893       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun merged commit 2f28257 into apache:dev Nov 19, 2023
53 checks passed
@ruanwenjun
Copy link
Member

Thanks, merged.

@Gallardot Gallardot deleted the filter-tasktype branch November 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][UI] shows supported task types on the front-end UI
3 participants