[fix-#13045] fix endless loop

[fuchanghai]

Purpose of the pull request

This PR is complementary to issue #13045

PR #13051

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

[fuchanghai]

@zhuangchong PTAL. cc @huage1994

[EricGao888]

Will this patch fix the endless loop when completing data?

[fuchanghai]

Will this patch fix the endless loop when completing data?

yes ,in #13051 ,forgot to add the corresponding event processing class, resulting in the status of the process instance not being updated

[EricGao888]

I'm still a little confused here. If a workflow instance fails to get submitted in data complement mode, in line 45, we directly return true without doing anything else to it. What will the state of the workflow instance become? Failure or just hanging there?

[fuchanghai]

I'm still a little confused here. If a workflow instance fails to get submitted in data complement mode, in line 45, we directly return true without doing anything else to it. What will the state of the workflow instance become? Failure or just hanging there?

You are right, whatever type, as long as an error occurs during the submission phase, the status should be updated to failure

[codecov-commenter]

Codecov Report

Merging #15092 (9989718) into dev (5e135ba) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 9989718 differs from pull request most recent head f651677. Consider uploading reports for the commit f651677 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15092      +/-   ##
============================================
- Coverage     38.19%   38.17%   -0.02%     
+ Complexity     4686     4682       -4     
============================================
  Files          1280     1281       +1     
  Lines         45325    45347      +22     
  Branches       4938     4941       +3     
============================================
  Hits          17312    17312              
- Misses        26126    26148      +22     
  Partials       1887     1887              

Files	Coverage Δ
...server/master/event/WorkflowStartEventHandler.java	0.00% <ø> (ø)
...ter/event/WorkflowSubmitFailStateEventHandler.java	0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[fuchanghai]

@huage1994 PTAL cc @ruanwenjun

[EricGao888]

BTW, you need to change the log information here:

dolphinscheduler/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java

Lines 70 to 79 in 8c01fcf

	} else if (WorkflowStartStatus.FAILED == workflowStartStatus) {
	log.error(
	"Failed to submit the workflow instance, will resend the workflow start event: {}",
	workflowEvent);
	WorkflowStateEvent stateEvent = WorkflowStateEvent.builder()
	.processInstanceId(processInstance.getId())
	.type(StateEventType.PROCESS_SUBMIT_FAILED)
	.status(WorkflowExecutionStatus.FAILURE)
	.build();
	workflowExecuteRunnable.addStateEvent(stateEvent);

If DS fails to submit a workflow instance, it no more resends the start event.

[fuchanghai]

BTW, you need to change the log information here:

dolphinscheduler/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java

Lines 70 to 79 in 8c01fcf

	} else if (WorkflowStartStatus.FAILED == workflowStartStatus) {
	log.error(
	"Failed to submit the workflow instance, will resend the workflow start event: {}",
	workflowEvent);
	WorkflowStateEvent stateEvent = WorkflowStateEvent.builder()
	.processInstanceId(processInstance.getId())
	.type(StateEventType.PROCESS_SUBMIT_FAILED)
	.status(WorkflowExecutionStatus.FAILURE)
	.build();
	workflowExecuteRunnable.addStateEvent(stateEvent);

If DS fails to submit a workflow instance, it no more resends the start event.

done

[huage1994]

LGTM

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
22.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint