[Improvement][Tools] Remove Mapper usage in upgrade tools #15073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS,
zhongjiajie and
EricGao888
as code owners
github-actions
bot
added
improvement
ruanwenjun
force-pushed
the
dev_wenjun_addPGV16IT
branch
10 times, most recently
from
0e86040
to
8be4282
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addPGV16IT
branch
from
8be4282
to
24a655e
Compare
The one bug is a regex, this is old code, I don't want to change in this pr.
|
caishunfeng
reviewed
Oct 25, 2023
| @@ -130,19 +130,16 @@ | |||
| <dependency> | |||
| <groupId>org.testcontainers</groupId> | |||
| <artifactId>mysql</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
why remove this scope?
There was a problem hiding this comment.
Since the scope is managed at dolphinscheduler-bom
|
LGTM, can you add some docs for guiding on how to write an upgrade program and why we should remove mapper? |
caishunfeng
approved these changes
Oct 25, 2023
|
SonarCloud Quality Gate failed.
|
ruanwenjun
changed the title
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #15069
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md