Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Master] Calculate the remainTime then we set the delay execution. #15012

Merged
merged 6 commits into from
Oct 11, 2023
Merged

[Improvement][Master] Calculate the remainTime then we set the delay execution. #15012

merged 6 commits into from
Oct 11, 2023

Conversation

dbac
Copy link
Contributor

@dbac dbac commented Oct 11, 2023

Fix #15007

@qingwli qingwli added the bug Something isn't working label Oct 11, 2023
@qingwli
Copy link
Member

qingwli commented Oct 11, 2023

Run 'mvn spotless:apply' to fix these violations.

@dbac dbac changed the title [Fix-#15007][worker-server] fix bug task delay execution [Fix-#15007][master-server] fix bug task delay execution Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #15012 (d325974) into dev (23b2c8a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d325974 differs from pull request most recent head 656988f. Consider uploading reports for the commit 656988f to get more accurate results

@@             Coverage Diff              @@
##                dev   #15012      +/-   ##
============================================
+ Coverage     38.89%   38.91%   +0.02%     
+ Complexity     4614     4611       -3     
============================================
  Files          1236     1236              
  Lines         43445    43415      -30     
  Branches       4805     4792      -13     
============================================
- Hits          16897    16896       -1     
+ Misses        24676    24646      -30     
- Partials       1872     1873       +1
Files Coverage Δ
.../runner/GlobalTaskInstanceDispatchQueueLooper.java 0.00% <0.00%> (ø)
...c/LogicITaskInstanceDispatchOperationFunction.java 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanwenjun ruanwenjun changed the title [Fix-#15007][master-server] fix bug task delay execution [Fix-#15007][master-server] Calculate the remainTime then we set the delay execution. Oct 11, 2023
ruanwenjun
ruanwenjun approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the changed logic is more reasonable.

But I don't think this will cause bug if you find there exist something is not correct, you need to check if the clock is not correct. So I remove the bug label.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Oct 11, 2023
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly and removed bug Something isn't working first time contributor First-time contributor labels Oct 11, 2023
@ruanwenjun ruanwenjun added this to the 3.2.1 milestone Oct 11, 2023
@SbloodyS SbloodyS added the first time contributor First-time contributor label Oct 11, 2023
@qingwli qingwli changed the title [Fix-#15007][master-server] Calculate the remainTime then we set the delay execution. [Improvement][Master] Calculate the remainTime then we set the delay execution. Oct 11, 2023
ruanwenjun
ruanwenjun approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

fuchanghai
fuchanghai approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

qingwli
qingwli approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qingwli qingwli merged commit d683553 into apache:dev Oct 11, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchanghai fuchanghai fuchanghai approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@qingwli qingwli qingwli approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@dbac dbac

Labels
backend first time contributor First-time contributor improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

[Bug] [worker-server] task delay execution
6 participants
@dbac @qingwli @codecov-commenter @ruanwenjun @fuchanghai @SbloodyS