Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][K8S] Remove ResourceQuota #14991

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added UI ui and front end related backend labels Oct 8, 2023
@Radeity Radeity added improvement make more easy to user or prompt friendly 3.2.1 labels Oct 8, 2023
@Radeity Radeity added this to the 3.2.1 milestone Oct 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@Gallardot Gallardot changed the title [Improvement][K8S] Remove ResourceQuota [WIP][Improvement][K8S] Remove ResourceQuota Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #14991 (ac02d3b) into dev (8665951) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head ac02d3b differs from pull request most recent head 9c7daf6. Consider uploading reports for the commit 9c7daf6 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14991      +/-   ##
============================================
- Coverage     38.22%   38.19%   -0.03%     
+ Complexity     4693     4681      -12     
============================================
  Files          1280     1280              
  Lines         45408    45325      -83     
  Branches       4953     4940      -13     
============================================
- Hits          17355    17311      -44     
+ Misses        26160    26127      -33     
+ Partials       1893     1887       -6     
Files Coverage Δ
...heduler/api/controller/K8sNamespaceController.java 78.94% <100.00%> (-2.88%) ⬇️
...che/dolphinscheduler/api/k8s/K8sClientService.java 8.00% <ø> (+3.00%) ⬆️
...uler/api/service/impl/K8SNamespaceServiceImpl.java 70.00% <100.00%> (+1.70%) ⬆️
...e/dolphinscheduler/common/constants/Constants.java 75.00% <ø> (ø)
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 18.18% <ø> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Gallardot Gallardot marked this pull request as ready for review October 23, 2023 10:12
@Gallardot Gallardot changed the title [WIP][Improvement][K8S] Remove ResourceQuota [Improvement][K8S] Remove ResourceQuota Oct 23, 2023
Signed-off-by: Gallardot <[email protected]>
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS merged commit 8c01fcf into apache:dev Nov 3, 2023
60 checks passed
@Gallardot Gallardot deleted the remove_quota branch November 3, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][K8S] Remove ResourceQuota
4 participants