-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][K8S] Remove ResourceQuota #14991
Conversation
...ler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java
Fixed
Show fixed
Hide fixed
...scheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/K8sNamespaceService.java
Fixed
Show fixed
Hide fixed
Please retry analysis of this Pull-Request directly on SonarCloud. |
8305520
to
cfd6565
Compare
Signed-off-by: Gallardot <[email protected]>
4847268
to
5d03771
Compare
Codecov Report
@@ Coverage Diff @@
## dev #14991 +/- ##
============================================
- Coverage 38.22% 38.19% -0.03%
+ Complexity 4693 4681 -12
============================================
Files 1280 1280
Lines 45408 45325 -83
Branches 4953 4940 -13
============================================
- Hits 17355 17311 -44
+ Misses 26160 26127 -33
+ Partials 1893 1887 -6
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Signed-off-by: Gallardot <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
...ler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java
Show resolved
Hide resolved
Signed-off-by: Gallardot <[email protected]>
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
Signed-off-by: Gallardot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md