Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-14916][dolphinscheduler-alert] alert message contains the taskPriority #14919

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

chenshuai1995
Copy link
Contributor

Purpose of the pull request

Fix #14916

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable mergeable bot removed the backend label Sep 14, 2023
@Radeity Radeity added improvement make more easy to user or prompt friendly backend labels Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #14919 (0212212) into dev (f6a6794) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 0212212 differs from pull request most recent head 4200d3d. Consider uploading reports for the commit 4200d3d to get more accurate results

@@             Coverage Diff              @@
##                dev   #14919      +/-   ##
============================================
- Coverage     38.86%   38.82%   -0.05%     
+ Complexity     4589     4588       -1     
============================================
  Files          1234     1234              
  Lines         43381    43384       +3     
  Branches       4793     4793              
============================================
- Hits          16861    16842      -19     
- Misses        24655    24679      +24     
+ Partials       1865     1863       -2     
Files Changed Coverage Δ
...inscheduler/service/alert/ProcessAlertManager.java 35.84% <0.00%> (-5.87%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity Radeity added this to the 3.2.1 milestone Sep 15, 2023
@Radeity Radeity added the 3.2.1 label Sep 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rickchengx rickchengx merged commit 6dcc26f into apache:dev Sep 15, 2023
53 checks passed
@zhongjiajie zhongjiajie modified the milestones: 3.2.1, 3.2.0 Oct 11, 2023
zhongjiajie pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Jim Chen <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
(cherry picked from commit 6dcc26f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][dolphinscheduler-alert] alert message contains the taskPriority
6 participants