[Fix-14729] fix problem with the command generated by the flink task #14902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiuCanWu
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
SbloodyS
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #14902 +/- ##
=========================================
Coverage 38.81% 38.81%
- Complexity 4588 4590 +2
=========================================
Files 1234 1234
Lines 43385 43387 +2
Branches 4794 4792 -2
=========================================
+ Hits 16841 16842 +1
- Misses 24680 24681 +1
Partials 1864 1864
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Do you think this pr needs cherry-picked to 3.1.9? @zhuangchong |
|
Kudos, SonarCloud Quality Gate passed! |
zhongjiajie
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: 刘阳 <[email protected]> Co-authored-by: xiangzihao <[email protected]> (cherry picked from commit e748c2e)
zhuangchong
added
the
release cherry-pick
zhuangchong
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #14729
Brief change log
1、The determinedYarnQueue method in the FlinkArgsUtils class and the switch statement of the doAddQueue method lack a break, adn I fix it.
2、 put the -Dyarn or -yqu parameter before -c, put the determinedYarnQueue method on line 284 before line 261
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md