Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null app-info-path cause NPE #14752

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Aug 15, 2023

Purpose of the pull request

[ERROR] 2023-08-15 16:10:28.329 +0800 org.apache.dolphinscheduler.service.utils.ProcessUtils:[195] - [WorkflowInstance-5][TaskInstance-7] - Kill yarn job failure, taskInstanceId: 7
java.lang.NullPointerException: taskAppInfoPath is marked non-null but is null
	at org.apache.dolphinscheduler.service.log.LogClient.getAppIds(LogClient.java:214)
	at org.apache.dolphinscheduler.service.utils.ProcessUtils.killApplication(ProcessUtils.java:173)
	at org.apache.dolphinscheduler.server.master.service.WorkerFailoverService.failoverTaskInstance(WorkerFailoverService.java:184)
	at org.apache.dolphinscheduler.server.master.service.WorkerFailoverService.failoverWorker(WorkerFailoverService.java:144)
	at org.apache.dolphinscheduler.server.master.service.FailoverService.failoverServerWhenDown(FailoverService.java:55)
	at org.apache.dolphinscheduler.server.master.registry.MasterRegistryClient.removeWorkerNodePath(MasterRegistryClient.java:142)
	at org.apache.dolphinscheduler.server.master.registry.MasterRegistryDataListener.handleWorkerEvent(MasterRegistryDataListener.java:77)
	at org.apache.dolphinscheduler.server.master.registry.MasterRegistryDataListener.notify(MasterRegistryDataListener.java:50)
	at org.apache.dolphinscheduler.plugin.registry.zookeeper.ZookeeperRegistry.lambda$subscribe$1(ZookeeperRegistry.java:147)
	at org.apache.curator.framework.recipes.cache.TreeCache.lambda$callListeners$1(TreeCache.java:811)
	at org.apache.curator.framework.listen.MappingListenerManager.lambda$forEach$0(MappingListenerManager.java:92)
	at org.apache.curator.framework.listen.MappingListenerManager.forEach(MappingListenerManager.java:89)
	at org.apache.curator.framework.listen.StandardListenerManager.forEach(StandardListenerManager.java:89)
	at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:807)
	at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:79)
	at org.apache.curator.framework.recipes.cache.TreeCache$2.run(TreeCache.java:909)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity Radeity added bug Something isn't working 3.2.0 for 3.2.0 version labels Aug 15, 2023
@Radeity Radeity added this to the 3.2.0 milestone Aug 15, 2023
@Radeity Radeity self-assigned this Aug 15, 2023
@Radeity Radeity marked this pull request as draft August 16, 2023 06:18
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #14752 (41f7f0e) into dev (59998f4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 41f7f0e differs from pull request most recent head b483bf9. Consider uploading reports for the commit b483bf9 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14752      +/-   ##
============================================
- Coverage     38.78%   38.74%   -0.04%     
+ Complexity     4675     4673       -2     
============================================
  Files          1288     1288              
  Lines         44251    44253       +2     
  Branches       4881     4879       -2     
============================================
- Hits          17161    17148      -13     
- Misses        25190    25207      +17     
+ Partials       1900     1898       -2     
Files Changed Coverage Δ
...nscheduler/remote/command/log/GetAppIdRequest.java 0.00% <ø> (ø)
...nscheduler/remote/processor/GetAppIdProcessor.java 0.00% <0.00%> (ø)
...apache/dolphinscheduler/service/log/LogClient.java 0.00% <0.00%> (ø)
...e/dolphinscheduler/service/utils/ProcessUtils.java 25.92% <0.00%> (ø)
...lphinscheduler/plugin/task/api/utils/LogUtils.java 36.14% <0.00%> (-0.45%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
0.0% 0.0% Duplication

@Radeity Radeity marked this pull request as ready for review August 19, 2023 05:15
@ruanwenjun ruanwenjun merged commit a491e3a into apache:dev Aug 19, 2023
52 checks passed
@Radeity Radeity deleted the app-info-path-npe branch August 19, 2023 05:38
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 21, 2023
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants