Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-14668][dolphinscheduler-tools] Modify the imported jar package. Use org.apache.commons.lang3.StringUtils. #14669

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

alei1206
Copy link
Contributor

@alei1206 alei1206 commented Jul 31, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI pass.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #14669 (b9123ac) into dev (9963bfc) will not change coverage.
The diff coverage is n/a.

❗ Current head b9123ac differs from pull request most recent head 09174c4. Consider uploading reports for the commit 09174c4 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14669   +/-   ##
=========================================
  Coverage     38.71%   38.71%           
  Complexity     4626     4626           
=========================================
  Files          1285     1285           
  Lines         43951    43951           
  Branches       4852     4852           
=========================================
  Hits          17016    17016           
  Misses        25056    25056           
  Partials       1879     1879           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Radeity Radeity added bug Something isn't working 3.2.0 for 3.2.0 version labels Jul 31, 2023
@Radeity Radeity added this to the 3.2.0 milestone Jul 31, 2023
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidzollo
Copy link
Contributor

Running the CI

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Radeity Radeity merged commit 139f230 into apache:dev Aug 2, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
…Use org.apache.commons.lang3.StringUtils. (#14669)

(cherry picked from commit 139f230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working ready-to-merge
Projects
None yet
5 participants