Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] [E2E] Add e2e optional for ci #14633

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[Chore] [E2E] Add e2e optional for ci #14633

merged 1 commit into from
Jul 25, 2023

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

#14606 (comment)

@SbloodyS SbloodyS added CI&CD minor Chore Chores about the project, like code clean, typo, etc. 3.2.0 for 3.2.0 version labels Jul 25, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jul 25, 2023
@SbloodyS SbloodyS added the e2e e2e test label Jul 25, 2023
@github-actions github-actions bot removed the e2e e2e test label Jul 25, 2023
@SbloodyS SbloodyS added the e2e e2e test label Jul 25, 2023
@SbloodyS SbloodyS assigned SbloodyS and unassigned zhongjiajie and EricGao888 Jul 25, 2023
zhongjiajie
zhongjiajie approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #14633 (7bc32eb) into dev (6617e3f) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7bc32eb differs from pull request most recent head 5e883b6. Consider uploading reports for the commit 5e883b6 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14633      +/-   ##
============================================
- Coverage     38.54%   38.52%   -0.02%     
+ Complexity     4583     4579       -4     
============================================
  Files          1260     1260              
  Lines         43808    43808              
  Branches       4836     4838       +2     
============================================
- Hits          16884    16879       -5     
- Misses        25051    25056       +5     
  Partials       1873     1873

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SbloodyS SbloodyS merged commit 1641544 into apache:dev Jul 25, 2023
@SbloodyS SbloodyS deleted the add_e2e_option_for_ci branch July 25, 2023 03:10
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
@SbloodyS @biaoma-ty
add e2e optional for ci (apache#14633)
7aa3596
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
@SbloodyS @zhongjiajie
add e2e optional for ci (#14633)
9556a7c 
(cherry picked from commit 1641544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888

Assignees

@SbloodyS SbloodyS

Labels
3.2.0 for 3.2.0 version CI&CD e2e e2e test minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SbloodyS @codecov-commenter @zhongjiajie @EricGao888