Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] [Chore] Increase browser container timeout #14608

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[CI] [Chore] Increase browser container timeout #14608

merged 3 commits into from
Jul 20, 2023

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Jul 20, 2023 •
edited
Loading

@SbloodyS SbloodyS added CI&CD minor Chore Chores about the project, like code clean, typo, etc. 3.2.0 for 3.2.0 version labels Jul 20, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jul 20, 2023
@SbloodyS SbloodyS self-assigned this Jul 20, 2023
@github-actions github-actions bot added e2e e2e test and removed CI&CD labels Jul 20, 2023
@SbloodyS SbloodyS marked this pull request as ready for review July 20, 2023 10:10
@SbloodyS SbloodyS requested a review from EricGao888 July 20, 2023 10:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #14608 (5870480) into dev (1d0d85b) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5870480 differs from pull request most recent head af24826. Consider uploading reports for the commit af24826 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14608      +/-   ##
============================================
+ Coverage     38.51%   38.53%   +0.02%     
- Complexity     4562     4564       +2     
============================================
  Files          1260     1260              
  Lines         43791    43791              
  Branches       4829     4829              
============================================
+ Hits          16864    16873       +9     
+ Misses        25054    25044      -10     
- Partials       1873     1874       +1

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhongjiajie
zhongjiajie approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make ci more stable

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SbloodyS SbloodyS merged commit 149ff49 into apache:dev Jul 20, 2023
@SbloodyS SbloodyS deleted the fix_flaky_e2e_test branch July 20, 2023 11:51
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
@SbloodyS @biaoma-ty
increase browser container timeout (apache#14608)
9cd065c
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
@SbloodyS @zhongjiajie
increase browser container timeout (#14608)
284fd2a 
(cherry picked from commit 149ff49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888

Assignees

@SbloodyS SbloodyS

Labels
3.2.0 for 3.2.0 version e2e e2e test minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SbloodyS @codecov-commenter @zhongjiajie