Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][dolphinscheduler-api]validated for duplicate username when creating or registering a user #14577

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #14577 (31f6166) into dev (9778652) will increase coverage by 0.01%.
The diff coverage is 28.57%.

❗ Current head 31f6166 differs from pull request most recent head 9de79c8. Consider uploading reports for the commit 9de79c8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14577      +/-   ##
============================================
+ Coverage     38.60%   38.61%   +0.01%     
- Complexity     4541     4545       +4     
============================================
  Files          1241     1241              
  Lines         43548    43554       +6     
  Branches       4830     4832       +2     
============================================
+ Hits          16813    16820       +7     
  Misses        24861    24861              
+ Partials       1874     1873       -1     
Impacted Files Coverage Δ
...lphinscheduler/api/controller/UsersController.java 51.51% <16.66%> (-3.49%) ⬇️
...inscheduler/api/service/impl/UsersServiceImpl.java 70.83% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gallardot Gallardot marked this pull request as ready for review July 18, 2023 11:39
@SbloodyS SbloodyS added bug Something isn't working 3.2.0 for 3.2.0 version labels Jul 18, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jul 18, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

36.4% 36.4% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

36.4% 36.4% Coverage
0.0% 0.0% Duplication

@rickchengx rickchengx merged commit 804b715 into apache:dev Jul 19, 2023
@Gallardot Gallardot deleted the fix-user branch July 19, 2023 06:13
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
…ting or registering a user (#14577)

* [Bug][dolphinscheduler-api]validated for duplicate username when creating or registering a user

Signed-off-by: Gallardot <[email protected]>

* [Bug][dolphinscheduler-api]validated for duplicate username when creating or registering a user

Signed-off-by: Gallardot <[email protected]>

---------

Signed-off-by: Gallardot <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: Eric Gao <[email protected]>
(cherry picked from commit 804b715)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
…ting or registering a user (apache#14577)

* [Bug][dolphinscheduler-api]validated for duplicate username when creating or registering a user

Signed-off-by: Gallardot <[email protected]>

* [Bug][dolphinscheduler-api]validated for duplicate username when creating or registering a user

Signed-off-by: Gallardot <[email protected]>

---------

Signed-off-by: Gallardot <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: Eric Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-api] validated for duplicate username when creating or registering a user
7 participants