-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish config, expose rpc config in application.yml #14501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
397abfc
to
1ae8acd
Compare
1ae8acd
to
a8324f9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #14501 +/- ##
============================================
- Coverage 38.69% 38.64% -0.06%
+ Complexity 4572 4556 -16
============================================
Files 1237 1237
Lines 43483 43496 +13
Branches 4817 4817
============================================
- Hits 16827 16807 -20
- Misses 24789 24821 +32
- Partials 1867 1868 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SonarCloud Quality Gate failed. 0 Bugs 33.3% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
(cherry picked from commit 0246327)
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md