Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish config, expose rpc config in application.yml #14501

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jul 10, 2023

Purpose of the pull request

Brief change log

  • Move API related config under API tag
  • Expose netty config to master/worker's application.yaml

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added 3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly and removed backend document labels Jul 10, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Jul 10, 2023
caishunfeng
caishunfeng previously approved these changes Jul 10, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #14501 (4c837f9) into dev (406aeaf) will decrease coverage by 0.06%.
The diff coverage is 34.21%.

❗ Current head 4c837f9 differs from pull request most recent head a8324f9. Consider uploading reports for the commit a8324f9 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14501      +/-   ##
============================================
- Coverage     38.69%   38.64%   -0.06%     
+ Complexity     4572     4556      -16     
============================================
  Files          1237     1237              
  Lines         43483    43496      +13     
  Branches       4817     4817              
============================================
- Hits          16827    16807      -20     
- Misses        24789    24821      +32     
- Partials       1867     1868       +1     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/python/PythonGateway.java 17.22% <0.00%> (-0.08%) ⬇️
...e/dolphinscheduler/server/master/MasterServer.java 0.00% <0.00%> (ø)
...inscheduler/server/master/config/MasterConfig.java 1.81% <0.00%> (-0.07%) ⬇️
...inscheduler/server/master/rpc/MasterRPCServer.java 0.00% <0.00%> (ø)
...inscheduler/server/master/rpc/MasterRpcClient.java 7.14% <0.00%> (-2.86%) ⬇️
...inscheduler/server/worker/config/WorkerConfig.java 3.84% <ø> (ø)
...inscheduler/server/worker/rpc/WorkerRpcClient.java 6.66% <0.00%> (+0.41%) ⬆️
...inscheduler/server/worker/rpc/WorkerRpcServer.java 0.00% <0.00%> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 10.62% <14.28%> (ø)
...olphinscheduler/api/audit/AuditPublishService.java 34.61% <33.33%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ruanwenjun ruanwenjun merged commit 0246327 into apache:dev Jul 11, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_polishConfig branch July 11, 2023 01:56
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants