Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-14387][UI] Support to reset user's password. #14498

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #14387 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The test results are as follows:
image
image
image

@github-actions github-actions bot added the UI ui and front end related label Jul 10, 2023
@calvinjiang calvinjiang added UI ui and front end related improvement make more easy to user or prompt friendly 3.2.0 for 3.2.0 version labels Jul 10, 2023
@calvinjiang calvinjiang added this to the 3.2.0 milestone Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #14498 (4e2ec6a) into dev (3de0b5a) will decrease coverage by 0.03%.
The diff coverage is 30.76%.

❗ Current head 4e2ec6a differs from pull request most recent head cd04e1a. Consider uploading reports for the commit cd04e1a to get more accurate results

@@             Coverage Diff              @@
##                dev   #14498      +/-   ##
============================================
- Coverage     38.72%   38.70%   -0.03%     
+ Complexity     4575     4569       -6     
============================================
  Files          1237     1237              
  Lines         43477    43435      -42     
  Branches       4813     4785      -28     
============================================
- Hits          16838    16812      -26     
+ Misses        24772    24756      -16     
  Partials       1867     1867              
Impacted Files Coverage Δ
...scheduler/data/quality/DataQualityApplication.java 0.00% <0.00%> (ø)
...inscheduler/server/master/rpc/MasterRpcClient.java 10.00% <0.00%> (ø)
...r/server/master/service/WorkerFailoverService.java 56.66% <ø> (+0.46%) ⬆️
...scheduler/plugin/task/dq/utils/SparkArgsUtils.java 0.00% <0.00%> (ø)
...ata/quality/execution/SparkRuntimeEnvironment.java 73.68% <80.00%> (-2.79%) ⬇️

... and 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle CI errors.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhuangchong zhuangchong merged commit c3c2dda into apache:dev Jul 11, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Improvement] reset user password
4 participants