-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] DataQuality module improve #14463
Conversation
I have run the dq task locally, it can success even though I do not have hive install, do you mean default dq task must ask hive install to run ? |
...a-quality/src/main/java/org/apache/dolphinscheduler/data/quality/DataQualityApplication.java
Show resolved
Hide resolved
ci failed could you please task a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
cada88a
rerun the failed ci |
could you rebase to latest dev branch? CI |
re-run failed CI |
Codecov Report
@@ Coverage Diff @@
## dev #14463 +/- ##
============================================
- Coverage 38.54% 38.53% -0.02%
+ Complexity 4557 4555 -2
============================================
Files 1237 1237
Lines 43462 43420 -42
Branches 4814 4784 -30
============================================
- Hits 16754 16731 -23
+ Misses 24853 24836 -17
+ Partials 1855 1853 -2
... and 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SonarCloud Quality Gate failed. 0 Bugs 30.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
(cherry picked from commit 75d29f6)
Purpose of the pull request
Brief change log
Verify this pull request