[Feature-14421][K8S Task] Configurable image pull policy

[Radeity]

Purpose of the pull request

• This PR closes [Feature][K8S Task] Configurable image pull policy #14421

Brief change log

• Support to select image pull policy from IfNotPresent, Always, Never.

Verify this pull request

[codecov-commenter]

Codecov Report

Merging #14426 (7d52487) into dev (5cbe170) will decrease coverage by 0.01%.
The diff coverage is 54.09%.

❗ Current head 7d52487 differs from pull request most recent head 00eb446. Consider uploading reports for the commit 00eb446 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14426      +/-   ##
============================================
- Coverage     38.51%   38.51%   -0.01%     
+ Complexity     4566     4545      -21     
============================================
  Files          1237     1236       -1     
  Lines         43541    43410     -131     
  Branches       4813     4783      -30     
============================================
- Hits          16771    16720      -51     
+ Misses        24914    24832      -82     
- Partials       1856     1858       +2     

Impacted Files	Coverage Δ
...scheduler/api/dto/resources/ResourceComponent.java	26.66% <ø> (+1.66%)	⬆️
...api/dto/resources/visitor/ResourceTreeVisitor.java	72.09% <ø> (-0.64%)	⬇️
...nscheduler/api/security/impl/ldap/LdapService.java	5.76% <0.00%> (-0.62%)	⬇️
...heduler/api/service/impl/ResourcesServiceImpl.java	44.53% <ø> (+0.67%)	⬆️
...cheduler/common/constants/DataSourceConstants.java	0.00% <ø> (ø)
...heduler/common/log/remote/OssRemoteLogHandler.java	0.00% <0.00%> (ø)
...apache/dolphinscheduler/dao/entity/DataSource.java	18.18% <ø> (ø)
...asource/api/datasource/BaseDataSourceParamDTO.java	40.42% <ø> (+4.57%)	⬆️
...nscheduler/service/process/ProcessServiceImpl.java	30.76% <ø> (-0.22%)	⬇️
.../org/apache/dolphinscheduler/spi/enums/DbType.java	0.00% <0.00%> (ø)
... and 19 more

... and 38 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

93.8% Coverage
0.0% Duplication

[qingwli]

We have defined Always and Never in here:

dolphinscheduler/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java

Lines 482 to 483 in f186cd5

	public static final String IMAGE_PULL_POLICY = "Always";
	public static final String RESTART_POLICY = "Never";

Can we add a new constant IfNotPresent here and return a select list from API replace defined this in the UI module?

[Radeity]

Can we add a new constant IfNotPresent here and return a select list from API replace defined this in the UI module?

Hi, @qingwli , thanks for your comment. I think image pull policies are relative static options, and it's still possible that user define a k8s task with wrong image pull policy by openAPI. In addition, we have already defined many option list in front-end codes, maybe for simplicity. Thus, considering interaction through UI page, do we have to make this change?

[rickchengx]

LGTM

[Radeity]

Hi, @qingwli , do you have any other suggestions?

[qingwli]

I agree with you @Radeity