Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-14397][dao] the task node in the imported workflow definition was not displayed on the task definition page #14398

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

penggeyuanlishe
Copy link
Contributor

@penggeyuanlishe penggeyuanlishe commented Jun 22, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution :D

@Radeity Radeity added this to the 3.1.8 milestone Jun 24, 2023
@Radeity Radeity added the 3.1.x for 3.1.x version label Jun 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Merging #14398 (edd4d5f) into dev (3c04d5c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head edd4d5f differs from pull request most recent head 6c9d677. Consider uploading reports for the commit 6c9d677 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14398   +/-   ##
=========================================
  Coverage     38.55%   38.56%           
+ Complexity     4559     4556    -3     
=========================================
  Files          1236     1236           
  Lines         43451    43452    +1     
  Branches       4810     4812    +2     
=========================================
+ Hits          16754    16756    +2     
+ Misses        24839    24838    -1     
  Partials       1858     1858           
Impacted Files Coverage Δ
...dolphinscheduler/dao/entity/TaskDefinitionLog.java 18.18% <0.00%> (-0.43%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the latest dev branch.

@zhongjiajie
Copy link
Member

hi @penggeyuanlishe are you still there, could you please rebase the dev code to pass the CI?

@penggeyuanlishe
Copy link
Contributor Author

Please rebase the latest dev branch.
hi @penggeyuanlishe are you still there, could you please rebase the dev code to pass the CI?

ok

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@penggeyuanlishe
Copy link
Contributor Author

Please rebase the latest dev branch.
@SbloodyS @zhongjiajie have done !

@penggeyuanlishe
Copy link
Contributor Author

LGTM, thanks for your contribution :D

my pleasure !

@rickchengx rickchengx merged commit dec066f into apache:dev Jul 4, 2023
@zhongjiajie
Copy link
Member

@rickchengx Hi next time merging the pr, please notice the pr title, currently is Chinese now
image

@rickchengx
Copy link
Contributor

@rickchengx Hi next time merging the pr, please notice the pr title, currently is Chinese now image

Sure, my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
7 participants