Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration #14349

Merged
merged 6 commits into from
Jun 29, 2023
Merged

[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration #14349

merged 6 commits into from
Jun 29, 2023

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Jun 14, 2023

@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #14349 (d42dc69) into dev (c1a6790) will increase coverage by 0.01%.
The diff coverage is 37.50%.

❗ Current head d42dc69 differs from pull request most recent head 7549b5a. Consider uploading reports for the commit 7549b5a to get more accurate results

@@             Coverage Diff              @@
##                dev   #14349      +/-   ##
============================================
+ Coverage     38.47%   38.49%   +0.01%     
+ Complexity     4559     4558       -1     
============================================
  Files          1237     1237              
  Lines         43538    43494      -44     
  Branches       4814     4785      -29     
============================================
- Hits          16753    16741      -12     
+ Misses        24932    24901      -31     
+ Partials       1853     1852       -1
Impacted Files Coverage Δ
...nscheduler/api/security/impl/ldap/LdapService.java 5.76% <0.00%> (-0.62%) ⬇️
...dolphinscheduler/plugin/task/datax/DataxUtils.java 0.00% <0.00%> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 10.65% <66.66%> (ø)

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qingwli
Copy link
Member Author

qingwli commented Jun 19, 2023

PTAL @kezhenxu94

kezhenxu94
kezhenxu94 previously approved these changes Jun 28, 2023
View reviewed changes
@qingwli
Copy link
Member Author

qingwli commented Jun 28, 2023

@SbloodyS Help rerun failed ut

@SbloodyS
Copy link
Member

@SbloodyS Help rerun failed ut

There are many CI failed. You should check it.

@qingwli
Copy link
Member Author

qingwli commented Jun 28, 2023

@SbloodyS Help rerun failed ut

There are many CI failed. You should check it.

cluster-test-postgresql Error. But I change nothing about pgsql
Docs error Fixed by other pr
E2E looks like timeout

@SbloodyS
Copy link
Member

You can try rebase the latest dev code. @qingwli

@qingwli qingwli requested a review from ruanwenjun as a code owner June 28, 2023 08:46
@github-actions github-actions bot added the UI ui and front end related label Jun 28, 2023
@github-actions github-actions bot removed the UI ui and front end related label Jun 28, 2023
@qingwli
Copy link
Member Author

qingwli commented Jun 28, 2023

You can try rebase the latest dev code. @qingwli

help run ut

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@qingwli
Copy link
Member Author

qingwli commented Jun 28, 2023

@SbloodyS help rerun e2e

@zhongjiajie
Copy link
Member

approval rerun ci

@qingwli
Copy link
Member Author

qingwli commented Jun 29, 2023

CI passed, help approved again @kezhenxu94

@kezhenxu94 kezhenxu94 merged commit f186cd5 into apache:dev Jun 29, 2023
@qingwli qingwli deleted the ldap-support-ssl branch June 29, 2023 08:21
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
@qingwli
[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration (apache…
59176ce 
…#14349)
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@qingwli @zhongjiajie
[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration (#14349)
28c2ec8 
(cherry picked from commit f186cd5)
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
@qingwli @biaoma-ty
[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration (apache…
f5e42dc 
…#14349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radeity Radeity Radeity left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@songjianet songjianet Awaiting requested review from songjianet

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun

Assignees

@qingwli qingwli

Labels
3.2.0 for 3.2.0 version backend document feature new feature kubernetes
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Feature][Api] LDAP SSL supports&& Add LDAP K8s configuration
6 participants
@qingwli @codecov-commenter @SbloodyS @zhongjiajie @kezhenxu94 @Radeity