Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][UI] Support CRUD of project-level parameters. #14344

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #14218 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    image

image

image

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable
Copy link

mergeable bot commented Jun 13, 2023

⚠️ This PR do not change database DDL synchronize.

@calvinjiang calvinjiang added this to the 3.2.0 milestone Jun 13, 2023
@calvinjiang calvinjiang added 3.2.0 for 3.2.0 version feature new feature labels Jun 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #14344 (8ad748a) into dev (a55612e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 8ad748a differs from pull request most recent head d10eec7. Consider uploading reports for the commit d10eec7 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14344      +/-   ##
============================================
- Coverage     38.50%   38.47%   -0.04%     
+ Complexity     4560     4557       -3     
============================================
  Files          1239     1239              
  Lines         43551    43555       +4     
  Branches       4816     4816              
============================================
- Hits          16771    16757      -14     
- Misses        24924    24946      +22     
+ Partials       1856     1852       -4     
Impacted Files Coverage Δ
.../api/service/impl/ProjectParameterServiceImpl.java 1.52% <0.00%> (-0.05%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong merged commit d4921fa into apache:dev Jun 13, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][UI] Support CRUD of project-level parameters
3 participants