Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim node selector requirement value #14307

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Jun 7, 2023

Purpose of the pull request

Brief change log

  • Trim value with regex \\s*,\\s*".

Verify this pull request

  • Add UT.

@SbloodyS SbloodyS added bug Something isn't working 3.2.0 for 3.2.0 version labels Jun 8, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #14307 (1ced794) into dev (e7cdc7c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1ced794 differs from pull request most recent head 33bf8ca. Consider uploading reports for the commit 33bf8ca to get more accurate results

@@             Coverage Diff              @@
##                dev   #14307      +/-   ##
============================================
+ Coverage     38.60%   38.61%   +0.01%     
- Complexity     4525     4527       +2     
============================================
  Files          1237     1237              
  Lines         43187    43187              
  Branches       4781     4781              
============================================
+ Hits          16672    16678       +6     
+ Misses        24679    24675       -4     
+ Partials       1836     1834       -2     
Impacted Files Coverage Δ
...ache/dolphinscheduler/plugin/task/k8s/K8sTask.java 80.48% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 2 Code Smells

7.1% 7.1% Coverage
0.0% 0.0% Duplication

Copy link
Member

@EricGao888 EricGao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just restarted the failed CI jobs, waiting for them to complete.

docs/docs/en/guide/task/kubernetes.md Show resolved Hide resolved
@rickchengx rickchengx merged commit b7fb393 into apache:dev Jun 9, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants