Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-#14148][Task] Added status check interval and dependent failure policy parameters for dependent task nodes #14150

Merged
merged 5 commits into from
May 19, 2023

Conversation

zhuangchong
Copy link
Contributor

@zhuangchong zhuangchong commented May 19, 2023

Purpose of the pull request

close #14148

iShot_2023-05-19_10 16 47
iShot_2023-05-19_10 16 57

Set the check interval to 60s, rely on failure waiting, and the failure waiting time is 5 minutes
iShot_2023-05-19_10 10 24

Case 1:
iShot_2023-05-19_10 06 57

Case 2:
iShot_2023-05-19_10 09 53

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@zhuangchong zhuangchong added feature new feature 3.2.0 for 3.2.0 version labels May 19, 2023
@zhuangchong zhuangchong added this to the 3.2.0 milestone May 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #14150 (7f23b57) into dev (8583de8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 7f23b57 differs from pull request most recent head bff7875. Consider uploading reports for the commit bff7875 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14150   +/-   ##
=========================================
  Coverage     38.39%   38.40%           
  Complexity     4456     4456           
=========================================
  Files          1223     1223           
  Lines         42544    42549    +5     
  Branches       4715     4718    +3     
=========================================
+ Hits          16334    16340    +6     
+ Misses        24411    24408    -3     
- Partials       1799     1801    +2     
Impacted Files Coverage Δ
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.44% <ø> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 10.33% <ø> (+<0.01%) ⬆️
...k/dependent/DependentAsyncTaskExecuteFunction.java 0.00% <0.00%> (ø)
...cheduler/server/master/utils/DependentExecute.java 0.00% <0.00%> (ø)
...lugin/task/api/parameters/DependentParameters.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong self-assigned this May 19, 2023
Copy link
Contributor

@calvinjiang calvinjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinjiang calvinjiang merged commit 8315279 into apache:dev May 19, 2023
@zhuangchong zhuangchong deleted the dependent-failure-policy branch May 19, 2023 06:56
ly109974 pushed a commit to ly109974/dolphinscheduler that referenced this pull request Apr 26, 2024
…and dependent failure policy parameters for dependent task nodes apache#14150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Task] Added status check interval and dependent failure policy parameters for dependent task nodes
3 participants