Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported operations of workflow definition #14122

Merged
merged 1 commit into from
May 18, 2023

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@rickchengx rickchengx self-assigned this May 16, 2023
@rickchengx rickchengx added this to the 3.2.0 milestone May 16, 2023
@@ -128,6 +128,9 @@ The following are the operation functions of the workflow definition list:
- **Timing Management:** The timing management page can edit, online or offline and delete timing.
- **Delete:** Delete the workflow definition. In the same project, only the workflow definition created by yourself can be deleted, and the workflow definition of other users cannot be deleted. If you need to delete it, please contact the user who created it or the administrator.
- **Download:** Download workflow definition to local.
- **Copy:** Copy a new workflow based on the current workflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some notice to tell users can copy to both some project or to others project?
BTW, we should also tell user when they copy the workflow, the workflow name will and copy date as is post to compare between previous tasks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment. I'll add this.

@github-actions github-actions bot added the UI ui and front end related label May 17, 2023
@rickchengx rickchengx added the 3.2.0 for 3.2.0 version label May 17, 2023
@rickchengx
Copy link
Contributor Author

  1. update the batch operations on the ui
image
  1. remove duplicate text in docs/docs/en/guide/project/workflow-definition.md

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #14122 (ff99803) into dev (c3809fb) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ff99803 differs from pull request most recent head c7db422. Consider uploading reports for the commit c7db422 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14122      +/-   ##
============================================
+ Coverage     38.39%   38.41%   +0.01%     
- Complexity     4456     4461       +5     
============================================
  Files          1223     1223              
  Lines         42541    42543       +2     
  Branches       4714     4713       -1     
============================================
+ Hits          16333    16342       +9     
+ Misses        24409    24401       -8     
- Partials       1799     1800       +1     
Impacted Files Coverage Δ
...duler/plugin/storage/hdfs/HdfsStorageOperator.java 19.86% <ø> (ø)
...server/worker/utils/TaskExecutionCheckerUtils.java 7.69% <0.00%> (-0.18%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label May 17, 2023
@zhongjiajie zhongjiajie changed the title [Doc-14121] Add supported operations of workflow definition Add supported operations of workflow definition May 18, 2023
@zhongjiajie
Copy link
Member

  1. update the batch operations on the ui
image 2. remove duplicate text in `docs/docs/en/guide/project/workflow-definition.md`

well done, BTW a little tips here, the next time when your pr scope changed you should also change the pr title. in this case we changed the scope from pure docs change to both docs and ui change

@zhongjiajie zhongjiajie merged commit db2da82 into apache:dev May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version document improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add supported operations of workflow definition
4 participants