Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-14080][script] cleanup dist directory at the beginning of check-LICENSE.sh #14081

Merged
merged 1 commit into from
May 23, 2023

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

  • cleanup dist directory at the beginning of check-LICENSE.sh
  • Avoid the interference of the pre-existing dist directory on the LICENSE check results

Verify this pull request

This pull request is code cleanup without any test coverage.

@rickchengx
Copy link
Contributor Author

Hi, @kezhenxu94 ,could you please help review this?

@zhongjiajie zhongjiajie added this to the 3.2.0 milestone May 12, 2023
@zhongjiajie zhongjiajie added minor Chore Chores about the project, like code clean, typo, etc. 3.2.0 for 3.2.0 version ready-to-merge labels May 12, 2023
@rickchengx rickchengx closed this May 18, 2023
@rickchengx rickchengx reopened this May 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #14081 (19134a1) into dev (67f50e3) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 19134a1 differs from pull request most recent head f909f7c. Consider uploading reports for the commit f909f7c to get more accurate results

@@             Coverage Diff              @@
##                dev   #14081      +/-   ##
============================================
- Coverage     38.39%   38.38%   -0.02%     
+ Complexity     4456     4453       -3     
============================================
  Files          1223     1223              
  Lines         42544    42544              
  Branches       4715     4715              
============================================
- Hits          16334    16329       -5     
- Misses        24411    24417       +6     
+ Partials       1799     1798       -1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rickchengx rickchengx closed this May 18, 2023
@rickchengx rickchengx reopened this May 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie
Copy link
Member

Hi @rickchengx you can directly restart the failed tests because you are a member of this this repos

@rickchengx rickchengx merged commit 0ab2447 into apache:dev May 23, 2023
@rickchengx rickchengx self-assigned this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][script] cleanup dist directory at the beginning of check-LICENSE.sh
4 participants