Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-13928][UI] Fix repeat CustomParams input box #14029

Merged
merged 1 commit into from
May 6, 2023

Conversation

imp2002
Copy link
Contributor

@imp2002 imp2002 commented Apr 27, 2023

Purpose of the pull request

Fix: #13928

Before:

Snipaste_2023-04-27_17-23-59

After fix:

image

Now all CustomParams seems use:

image

But forgot to remove the code about CustomParams written before, lead the repeat.

Brief change log

remove repeat code of CustomParams input box in datax Custom Template mode

Verify this pull request

This pull request is code cleanup without any test coverage.

@github-actions github-actions bot added the UI ui and front end related label Apr 27, 2023
@mergeable mergeable bot removed the UI ui and front end related label Apr 27, 2023
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor UI ui and front end related 3.1.6 labels Apr 28, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #14029 (ad4b150) into dev (4545093) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head ad4b150 differs from pull request most recent head 1178218. Consider uploading reports for the commit 1178218 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14029      +/-   ##
============================================
- Coverage     38.22%   38.20%   -0.03%     
+ Complexity     4437     4434       -3     
============================================
  Files          1220     1220              
  Lines         42698    42698              
  Branches       4734     4734              
============================================
- Hits          16322    16311      -11     
- Misses        24571    24586      +15     
+ Partials       1805     1801       -4     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SbloodyS SbloodyS requested a review from devosend May 6, 2023 09:11
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working first time contributor First-time contributor UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [datax] A custom template in datax, The user-defined parameter input box is abnormal
5 participants