Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix-#13940] add status of stop in class of TaskExecutionStatus #14016

Merged
merged 2 commits into from
May 18, 2023
Merged

[fix-#13940] add status of stop in class of TaskExecutionStatus #14016

merged 2 commits into from
May 18, 2023

Conversation

fuchanghai
Copy link
Member

Purpose of the pull request

this close:

Brief change log

add status of stop in class of TaskExecutionStatus

Verify this pull request

This pull request is code cleanup without any test coverage.

@fuchanghai
Copy link
Member Author

@caishunfeng @SbloodyS @zhuangchong plz run CI

@rickchengx
Copy link
Contributor

May I ask whether the READY_STOP state also needs to be added ?

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.9% 8.9% Coverage
6.1% 6.1% Duplication

@SbloodyS SbloodyS added 3.1.x for 3.1.x version bug Something isn't working labels May 17, 2023
@SbloodyS SbloodyS added this to the 3.1.7 milestone May 17, 2023
@fuchanghai
Copy link
Member Author

fuchanghai commented May 17, 2023 •
edited
Loading

May I ask whether the READY_STOP state also needs to be added ?

Sorry for not replying to you for so long.

我个人认为是不需要的，ready stop 不是一个finish 状态，只有subprocess 节点的流程实例finish状态才应该去更新父流程中的subprocess 任务实例的状态
I personally think it is unnecessary, ready stop is not a finish state, only the process instance finish state of the subprocess node should update the state of the subprocess task instance in the parent process

WDYT @rickchengx @caishunfeng @ruanwenjun

zhuangchong
zhuangchong approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

rickchengx
rickchengx approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangchong zhuangchong merged commit 67f50e3 into apache:dev May 18, 2023
zhuangchong pushed a commit that referenced this pull request May 18, 2023
@fuchanghai @zhuangchong
[fix-#13940] add status of stop in class of TaskExecutionStatus (
3281c97 
#14016)
@zhongjiajie zhongjiajie mentioned this pull request May 19, 2023
Closed
3 tasks
@HQFGit HQFGit mentioned this pull request May 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickchengx rickchengx rickchengx approved these changes

@zhuangchong zhuangchong zhuangchong approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@fuchanghai fuchanghai

Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Milestone
3.1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@fuchanghai @rickchengx @zhuangchong @SbloodyS