Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][API] update processInstance bug #13991

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Apr 22, 2023

Purpose of the pull request

Get this error when updating process instance

[ERROR] 2023-04-22 00:03:37.015 +0800 org.apache.dolphinscheduler.api.exceptions.ApiExceptionHandler:[52] - 更新工作流实例错误
org.springframework.web.bind.MissingServletRequestParameterException: Required request parameter 'tenantCode' for method parameter type String is not present
	at org.springframework.web.method.annotation.RequestParamMethodArgumentResolver.handleMissingValueInternal(RequestParamMethodArgumentResolver.java:218)
	at org.springframework.web.method.annotation.RequestParamMethodArgumentResolver.handleMissingValue(RequestParamMethodArgumentResolver.java:193)
	at org.springframework.web.method.annotation.AbstractNamedValueMethodArgumentResolver.resolveArgument(AbstractNamedValueMethodArgumentResolver.java:114)
	at org.springframework.web.method.support.HandlerMethodArgumentResolverComposite.resolveArgument(HandlerMethodArgumentResolverComposite.java:122)
	at org.springframework.web.method.support.InvocableHandlerMethod.getMethodArgumentValues(InvocableHandlerMethod.java:179)
	at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:146)
	at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
	...

Because after #13935, parameter tenantCode is useless and the api request doesn't contain parameter tenantCode.

Brief change log

  • Remove parameter tenantCode.

Verify this pull request

  • Update related UT.

@Radeity
Copy link
Member Author

Radeity commented Apr 22, 2023

cc @zhuangchong

@Radeity Radeity changed the title update processInstance bug [Bug][API] update processInstance bug Apr 22, 2023
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie added this to the 3.2.0 milestone Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #13991 (cc36c5b) into dev (5c1edd2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head cc36c5b differs from pull request most recent head 860021f. Consider uploading reports for the commit 860021f to get more accurate results

@@             Coverage Diff              @@
##                dev   #13991      +/-   ##
============================================
- Coverage     38.89%   38.88%   -0.02%     
- Complexity     4469     4472       +3     
============================================
  Files          1164     1164              
  Lines         42446    42445       -1     
  Branches       4761     4757       -4     
============================================
- Hits          16509    16504       -5     
- Misses        24118    24123       +5     
+ Partials       1819     1818       -1     
Impacted Files Coverage Δ
...uler/api/controller/ProcessInstanceController.java 69.56% <ø> (ø)
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.44% <100.00%> (-0.09%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie added 3.2.0 for 3.2.0 version bug Something isn't working labels Apr 24, 2023
@zhongjiajie zhongjiajie merged commit 73b505f into apache:dev Apr 24, 2023
@Radeity Radeity deleted the update-process-instance branch April 24, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants