Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug-13951 ][dolphinscheduler-service] StartParams is not applied when task is failover(RECOVER_TOLERANCE_FAULT_PROCESS CommandType) #13958

Merged
merged 1 commit into from
May 10, 2023
Merged

[Bug-13951 ][dolphinscheduler-service] StartParams is not applied when task is failover(RECOVER_TOLERANCE_FAULT_PROCESS CommandType) #13958

merged 1 commit into from
May 10, 2023

Conversation

minyk
Copy link
Contributor

@minyk minyk commented Apr 19, 2023 •
edited
Loading

Purpose of the pull request

This PR closes #13951

Brief change log

  1. During making a recovery command, Add StartParams of processInstance.getCommandParam() to command parameters
  2. When constructProcessInstance from command, setGlobalParamIfCommanded() called if command type is CommandType.RECOVER_TOLERANCE_FAULT_PROCESS

These are almost same actions of CommandType.REPEAT_RUNNING

Verify this pull request

This change added tests and can be verified as follows:

  • Added a test to ProcessServiceTest for verify the change.

@minyk minyk requested a review from caishunfeng as a code owner April 19, 2023 12:15
@fuchanghai
Copy link
Member

@SbloodyS @caishunfeng plz run CI

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Apr 20, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 20, 2023
@SbloodyS
Copy link
Member

@SbloodyS @caishunfeng plz run CI

Done.

@SbloodyS SbloodyS self-requested a review April 20, 2023 02:50
@minyk
Copy link
Contributor Author

minyk commented Apr 20, 2023

CI result indicates network problem?

./mvnw -B clean install \
Exception in thread "main" java.net.UnknownHostException: repo.maven.apache.org
	at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:229)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.base/java.net.Socket.connect(Socket.java:609)
	at java.base/sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:305)
	at java.base/sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:173)

Do I something to fix?

@SbloodyS
Copy link
Member

CI result indicates network problem?

./mvnw -B clean install \
Exception in thread "main" java.net.UnknownHostException: repo.maven.apache.org
	at java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:229)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
	at java.base/java.net.Socket.connect(Socket.java:609)
	at java.base/sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:305)
	at java.base/sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:173)

Do I something to fix?

It seems like the github actions problems. I've restarted CI.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.5% 38.5% Coverage
0.0% 0.0% Duplication

@minyk
Copy link
Contributor Author

minyk commented Apr 24, 2023 •
edited
Loading

Should I need to add more test cases?

@rickchengx
Copy link
Contributor

It seems that the CI needs to be restarted @SbloodyS

image

fuchanghai
fuchanghai approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SbloodyS
SbloodyS approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added the first time contributor First-time contributor label May 4, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.6, 3.1.7 May 10, 2023
@zhuangchong zhuangchong merged commit 801216b into apache:dev May 10, 2023
zhuangchong pushed a commit that referenced this pull request May 22, 2023
@minyk @zhuangchong
cherry-pick [Bug-13951 ][dolphinscheduler-service] StartParams is not…
9b094e9 
… applied when task is failover(RECOVER_TOLERANCE_FAULT_PROCESS CommandType) #13958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchanghai fuchanghai fuchanghai approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@minyk minyk

Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Milestone
3.1.7
5 participants
@minyk @fuchanghai @SbloodyS @rickchengx @zhuangchong