Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra default tenant in workflow save page #13867

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 4, 2023

Purpose of the pull request

Since the backend already have a default tenant, we will not need this.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Apr 4, 2023
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Apr 4, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Apr 4, 2023
@ruanwenjun ruanwenjun added the 3.2.0 for 3.2.0 version label Apr 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #13867 (25b5e21) into dev (69fc217) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 25b5e21 differs from pull request most recent head f980c5a. Consider uploading reports for the commit f980c5a to get more accurate results

@@             Coverage Diff              @@
##                dev   #13867      +/-   ##
============================================
- Coverage     39.08%   39.08%   -0.01%     
  Complexity     4459     4459              
============================================
  Files          1155     1155              
  Lines         42270    42270              
  Branches       4760     4760              
============================================
- Hits          16523    16520       -3     
- Misses        23936    23939       +3     
  Partials       1811     1811              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 6483395 into apache:dev Apr 4, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeExtraDefaultTenant branch April 4, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants