Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jdbc registry module #13812

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added 3.2.0 for 3.2.0 version feature new feature backend labels Mar 29, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #13812 (58c8d0e) into dev (1e8d09e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 58c8d0e differs from pull request most recent head 96f6ad8. Consider uploading reports for the commit 96f6ad8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13812      +/-   ##
============================================
- Coverage     39.08%   39.06%   -0.02%     
- Complexity     4439     4442       +3     
============================================
  Files          1132     1132              
  Lines         42163    42163              
  Branches       4746     4742       -4     
============================================
- Hits          16479    16473       -6     
- Misses        23878    23884       +6     
  Partials       1806     1806              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…lphinscheduler-registry-jdbc/README.md

Co-authored-by: kezhenxu94 <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit e074d7a into apache:dev Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants