[Improvement-13804] Optimal HDFS configuration acquisition (#13804) #13811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
reviewed
Mar 29, 2023
...-hdfs/src/main/java/org/apache/dolphinscheduler/plugin/storage/hdfs/HdfsStorageOperator.java
Outdated
Show resolved
Hide resolved
SbloodyS
added
first time contributor
Codecov Report
@@ Coverage Diff @@
## dev #13811 +/- ##
============================================
- Coverage 38.90% 38.89% -0.02%
+ Complexity 4470 4466 -4
============================================
Files 1164 1164
Lines 42444 42444
Branches 4761 4761
============================================
- Hits 16512 16507 -5
- Misses 24114 24116 +2
- Partials 1818 1821 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhaifb
force-pushed
the
Improvement-13804
branch
from
e446eb9
to
d8939fe
Compare
zhaifb
force-pushed
the
Improvement-13804
branch
2 times, most recently
from
d8cd6ae
to
e47dda7
Compare
zhaifb
force-pushed
the
Improvement-13804
branch
from
e47dda7
to
acaa87c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
SbloodyS
requested changes
Apr 20, 2023
...-hdfs/src/main/java/org/apache/dolphinscheduler/plugin/storage/hdfs/HdfsStorageOperator.java
Show resolved
Hide resolved
SbloodyS
approved these changes
Apr 20, 2023
xiaows08
pushed a commit
to xiaows08/dolphinscheduler
that referenced
this pull request
Apr 21, 2023
) (apache#13811) defaultFS key from FS_DEFAULT_FS to HDFS_DEFAULT_FS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultFS key from FS_DEFAULT_FS to HDFS_DEFAULT_FS
Purpose of the pull request
This pull request is Optimal HDFS configuration acquisition
change 1. from FS_DEFAULT_FS( resource.hdfs.fs.defaultFS ) to HDFS_DEFAULT_FS ( fs.defaultFS)
close #13804
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md