Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-13666] remove WORKER_GROUP in values.yaml #13718

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Mar 10, 2023

Purpose of the pull request

#13666 (comment)

Brief change log

Remove WORKER_GROUP in values.yaml

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #13718 (a762422) into dev (0db9164) will decrease coverage by 0.13%.
The diff coverage is 26.23%.

❗ Current head a762422 differs from pull request most recent head 6c2ac31. Consider uploading reports for the commit 6c2ac31 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13718      +/-   ##
============================================
- Coverage     39.21%   39.08%   -0.13%     
- Complexity     4410     4418       +8     
============================================
  Files          1113     1130      +17     
  Lines         41954    42052      +98     
  Branches       4778     4774       -4     
============================================
- Hits          16451    16436      -15     
- Misses        23672    23802     +130     
+ Partials       1831     1814      -17     
Impacted Files Coverage Δ
...inscheduler/api/controller/ExecutorController.java 17.94% <ø> (-1.04%) ⬇️
...cheduler/api/executor/ExecuteRuntimeException.java 0.00% <0.00%> (ø)
...ilure/recovery/FailureRecoveryExecuteFunction.java 0.00% <0.00%> (ø)
...low/instance/pause/pause/PauseExecuteFunction.java 0.00% <0.00%> (ø)
...instance/pause/recover/RecoverExecuteFunction.java 0.00% <0.00%> (ø)
...w/instance/rerun/RepeatRunningExecuteFunction.java 0.00% <0.00%> (ø)
...or/workflow/instance/stop/StopExecuteFunction.java 0.00% <0.00%> (ø)
...che/dolphinscheduler/api/python/PythonGateway.java 17.24% <0.00%> (-0.23%) ⬇️
...r/api/service/impl/ProcessInstanceServiceImpl.java 59.92% <0.00%> (-0.48%) ⬇️
...scheduler/api/service/impl/ProjectServiceImpl.java 62.35% <0.00%> (-0.56%) ⬇️
... and 84 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SbloodyS SbloodyS added bug Something isn't working backend 3.1.x for 3.1.x version labels Mar 10, 2023
@SbloodyS SbloodyS added this to the 3.1.5 milestone Mar 10, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants