Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][DataSource] add oceanbase datasource #13675

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

whhe
Copy link
Member

@whhe whhe commented Mar 5, 2023

Purpose of the pull request

Add oceanbase datasource.

Brief change log

Add module dolphinscheduler-datasource-oceanbase.

Verify this pull request

This pull request is manually verified by testing locally.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Merging #13675 (d181d5d) into dev (c9066e8) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head d181d5d differs from pull request most recent head fbfeaab. Consider uploading reports for the commit fbfeaab to get more accurate results

@@             Coverage Diff              @@
##                dev   #13675      +/-   ##
============================================
- Coverage     39.09%   39.02%   -0.08%     
+ Complexity     4419     4403      -16     
============================================
  Files          1127     1127              
  Lines         42052    42053       +1     
  Branches       4772     4772              
============================================
- Hits          16440    16410      -30     
- Misses        23797    23832      +35     
+ Partials       1815     1811       -4     
Impacted Files Coverage Δ
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
...r/plugin/task/sqoop/parameter/SqoopParameters.java 16.66% <0.00%> (-22.62%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

caishunfeng
caishunfeng previously approved these changes Mar 6, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@caishunfeng caishunfeng changed the title add oceanbase datasource [Feature][DataSource] add oceanbase datasource Mar 6, 2023
@caishunfeng caishunfeng added feature new feature 3.2.0 for 3.2.0 version labels Mar 6, 2023
@caishunfeng
Copy link
Contributor

Hi @whhe please check the fail CI case.
image

@whhe
Copy link
Member Author

whhe commented Mar 6, 2023

Hi @whhe please check the fail CI case. image

The failed link https://mvnrepository.com/artifact/com.oceanbase/oceanbase-client can be accessed in the browser, what should I do to fix it? I can replace it with https://central.sonatype.com/artifact/com.oceanbase/oceanbase-client/2.4.0/overview, but I'm not sure the CI result for it.

@caishunfeng
Copy link
Contributor

Hi @whhe please check the fail CI case. image

The failed link https://mvnrepository.com/artifact/com.oceanbase/oceanbase-client can be accessed in the browser, what should I do to fix it? I can replace it with https://central.sonatype.com/artifact/com.oceanbase/oceanbase-client/2.4.0/overview, but I'm not sure the CI result for it.

Yes, I have restart the deadlink check, but fail again. @zhongjiajie PTAL

ruanwenjun
ruanwenjun previously approved these changes Mar 6, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.2.0 milestone Mar 6, 2023
@zhongjiajie zhongjiajie dismissed stale reviews from ruanwenjun and caishunfeng via 833926e March 6, 2023 11:38
@zhongjiajie
Copy link
Member

CI keep failing, I try to merge the upstream branch

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

@zhongjiajie zhongjiajie merged commit 35d8e8a into apache:dev Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend document feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants