Add execute function to handle the workflow instance operation #13610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_splitCommandCreat
branch
from
f10eb89
to
b4fe38e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public interface ExecuteFunctionBuilder<Request extends ExecuteRequest, Result extends ExecuteResult> { | ||
|
|
||
| CompletableFuture<ExecuteFunction<Request, Result>> createWorkflowInstanceExecuteFunction(ExecuteContext executeContext); |
Check notice
Code scanning / CodeQL
Useless parameter
ruanwenjun
force-pushed
the
dev_wenjun_splitCommandCreat
branch
3 times, most recently
from
95e41a0
to
d818147
Compare
ruanwenjun
force-pushed
the
dev_wenjun_splitCommandCreat
branch
from
d818147
to
e8f8b33
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13610 +/- ##
============================================
- Coverage 39.21% 39.04% -0.17%
- Complexity 4410 4419 +9
============================================
Files 1113 1127 +14
Lines 41954 42096 +142
Branches 4778 4775 -3
============================================
- Hits 16451 16437 -14
- Misses 23672 23844 +172
+ Partials 1831 1815 -16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
caishunfeng
approved these changes
Feb 24, 2023
|
|
||
| package org.apache.dolphinscheduler.api.executor; | ||
|
|
||
| public interface ExecuteRequest { |
There was a problem hiding this comment.
Can you add some comment?
| @@ -236,6 +236,7 @@ public class ProcessDefinitionServiceImpl extends BaseServiceImpl implements Pro | |||
| @Autowired | |||
| private TaskDefinitionMapper taskDefinitionMapper; | |||
|
|
|||
| @Lazy | |||
There was a problem hiding this comment.
Can we avoid using this anno?
There was a problem hiding this comment.
After add dao we can remove the Lazy.
|
Can you ask which distribution this refactored code is on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md