Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-13504] Display the current project name on the left corner of the page #13572

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

QuantumXiecao
Copy link
Contributor

@QuantumXiecao QuantumXiecao commented Feb 15, 2023

Purpose of the pull request

[fix-13504] Display the current project name on the left corner of the page.

Releated PR: #13504

After fixing, the result would be as follows:
image

Brief change log

[fix-13504] Display the current project name on the left corner of the page.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Feb 15, 2023
@QuantumXiecao
Copy link
Contributor Author

image
@songjianet @Amy0104 Could you please do me a favour? This is my first PR. I do not see what this error means.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Feb 16, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what this issue #13504 wants to express is to display the project name in the upper left corner of the page. I can't see the meaning of displaying it on the url.

@QuantumXiecao
Copy link
Contributor Author

@SbloodyS I have updated my codes. And could you please help to label this issue for passing CI/CD's label check.
image

@SbloodyS
Copy link
Member

@SbloodyS I have updated my codes. And could you please help to label this issue for passing CI/CD's label check.

Done.

@QuantumXiecao QuantumXiecao changed the title [fix-13504] Display the current project name on the url param [fix-13504] Display the current project name on the left corner of the page Feb 16, 2023
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.2.0 for 3.2.0 version labels Feb 16, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Feb 16, 2023
@QuantumXiecao
Copy link
Contributor Author

image
@SbloodyS @songjianet @Amy0104 Sorry to disturb and I would like to know why it stuck here. Could you please help me out?

@Amy0104
Copy link
Member

Amy0104 commented Feb 17, 2023

I have rerun it.

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Amy0104 Amy0104 merged commit dd4804e into apache:dev Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version first time contributor First-time contributor improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants