Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][task node] task node resources improvement #13508

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

zhutong6688
Copy link
Contributor

@zhutong6688 zhutong6688 commented Feb 4, 2023

[Improvement][task node] task node includes shell、proceduce、sql、spark、datax、sqoop、flink_stream and so on,those can not select resource file by seraching resources tree。

Purpose of the pull request

The task node can use search filtering when selecting resources, even in the case of multi-level subdirectories, it can also use search to quickly filter resource files

Brief change log

Verify this pull request

version 3.1. x

manually test result

图片

[Improvement][task node] task node includes shell、proceduce、sql、spark、datax、sqoop、flink_stream and so on,those can not select resource file by seraching resources tree apache#13498
@github-actions github-actions bot added the UI ui and front end related label Feb 4, 2023
@zhutong6688 zhutong6688 closed this Feb 4, 2023
@zhutong6688 zhutong6688 reopened this Feb 4, 2023
@zhutong6688 zhutong6688 closed this Feb 4, 2023
@zhutong6688 zhutong6688 reopened this Feb 4, 2023
@davidzollo davidzollo added the first time contributor First-time contributor label Feb 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #13508 (da643dd) into dev (0ee82c5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #13508      +/-   ##
============================================
+ Coverage     39.60%   39.61%   +0.01%     
- Complexity     4356     4357       +1     
============================================
  Files          1097     1097              
  Lines         41156    41156              
  Branches       4714     4714              
============================================
+ Hits          16299    16304       +5     
+ Misses        23047    23040       -7     
- Partials       1810     1812       +2     
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 50.00% <0.00%> (+6.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhutong6688
Copy link
Contributor Author

This improvement will greatly improve user development efficiency when incorporated into the release version

@zhutong6688
Copy link
Contributor Author

At present, with such problems to be improved is version 3.1. x

@zhutong6688 zhutong6688 changed the title [Improvement][task node] task node resources improvement #13498 [Improvement][task node] task node resources improvement Feb 6, 2023
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 added this to the 3.1.4 milestone Feb 7, 2023
@Amy0104 Amy0104 added improvement make more easy to user or prompt friendly 3.1.x for 3.1.x version labels Feb 7, 2023
@Amy0104 Amy0104 merged commit 9a6f833 into apache:dev Feb 7, 2023
@zhutong6688 zhutong6688 removed their assignment Feb 7, 2023
@zhutong6688
Copy link
Contributor Author

@Amy0104 @davidzollo I accidentally clicked the “unsigned me” link, I was unintentional, now it's like this,
图片
Can you reassign me as the responsible person? Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version first time contributor First-time contributor improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants