Flinksql support standalone deploy mode #13495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyun
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
SbloodyS
added
3.2.0
Codecov Report
@@ Coverage Diff @@
## dev #13495 +/- ##
=========================================
Coverage 39.60% 39.61%
Complexity 4357 4357
=========================================
Files 1097 1097
Lines 41164 41169 +5
Branches 4716 4717 +1
=========================================
+ Hits 16305 16310 +5
+ Misses 23047 23046 -1
- Partials 1812 1813 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
EricGao888
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
LGTM, it would be better if u could add a UT case to https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java
ruanwenjun
changed the title
|
thanks for your first contribution, I'm looking forward to your deep participation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
feature flinksql support standalone deploy mode