Task instance failure when worker group doesn't exist #13448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
added
improvement
ruanwenjun
force-pushed
the
dev_wenjun_taskFailedWhenWorkerGroupDoesExist
branch
from
e56ac7d
to
50719a9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13448 +/- ##
============================================
- Coverage 39.59% 39.53% -0.07%
+ Complexity 4336 4334 -2
============================================
Files 1086 1087 +1
Lines 40955 40985 +30
Branches 4700 4701 +1
============================================
- Hits 16218 16205 -13
- Misses 22932 22976 +44
+ Partials 1805 1804 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caishunfeng
reviewed
Jan 29, 2023
...ter/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/ExecutorDispatcher.java
Show resolved
Hide resolved
...n/java/org/apache/dolphinscheduler/server/master/dispatch/executor/NettyExecutorManager.java
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_taskFailedWhenWorkerGroupDoesExist
branch
from
50719a9
to
3889c4c
Compare
ruanwenjun
force-pushed
the
dev_wenjun_taskFailedWhenWorkerGroupDoesExist
branch
from
3889c4c
to
873b9e4
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Set then task instance status to failure when the related worker group doesn't exist.
This may happen when user change the worker group name or worker group has been deleted.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md