Split the upgrade code #13436
Merged
Split the upgrade code #13436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS,
zhongjiajie and
EricGao888
as code owners
ruanwenjun
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #13436 +/- ##
============================================
- Coverage 39.57% 39.55% -0.03%
+ Complexity 4335 4331 -4
============================================
Files 1086 1086
Lines 40965 40928 -37
Branches 4700 4681 -19
============================================
- Hits 16213 16188 -25
+ Misses 22949 22934 -15
- Partials 1803 1806 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...hinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_splitUpgrade
branch
from
69a1c55
to
324a73b
Compare
ruanwenjun
force-pushed
the
dev_wenjun_splitUpgrade
branch
2 times, most recently
from
ea93647
to
f983eb4
Compare
|
The |
ruanwenjun
force-pushed
the
dev_wenjun_splitUpgrade
branch
from
f983eb4
to
ebf1198
Compare
2. Log the dml/ddl sql in origin friendly format 3. Fix ddl of 3.0.0 and 3.1.0
ruanwenjun
force-pushed
the
dev_wenjun_splitUpgrade
branch
from
ebf1198
to
eaba417
Compare
It looks correct to me, because it says these are fixed alerts
|
|
The reason why it fails is that, there is a new detected security issue here
|
|
SonarCloud Quality Gate failed. |
Thanks for your reminder, helps a lot. |
kezhenxu94
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md