Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source env list in common.properties #13317

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jan 3, 2023

Purpose of the pull request

Since use sudo -u to execute a shell task, the env will not load automatically, so we need to add default env list to load in shell task.

After this change, the env list will be loaded at the below order

source /etc/profile
source ~/.bash_profile
source user define profile

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #13317 (c7a1bf7) into dev (ccad56e) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##                dev   #13317      +/-   ##
============================================
- Coverage     39.55%   39.55%   -0.01%     
- Complexity     4294     4304      +10     
============================================
  Files          1072     1079       +7     
  Lines         40565    40645      +80     
  Branches       4656     4665       +9     
============================================
+ Hits          16045    16076      +31     
- Misses        22734    22780      +46     
- Partials       1786     1789       +3     
Impacted Files Coverage Δ
...cheduler/plugin/task/api/ShellCommandExecutor.java 0.00% <0.00%> (ø)
...hinscheduler/plugin/task/api/utils/ShellUtils.java 100.00% <100.00%> (ø)
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.08% <0.00%> (-0.70%) ⬇️
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
.../server/master/registry/MasterWaitingStrategy.java 0.00% <0.00%> (ø)
.../server/worker/registry/WorkerWaitingStrategy.java 0.00% <0.00%> (ø)
...source/dameng/param/DamengDataSourceProcessor.java 50.00% <0.00%> (ø)
...gin/datasource/dameng/DamengDataSourceChannel.java 50.00% <0.00%> (ø)
...asource/dameng/DamengDataSourceChannelFactory.java 66.66% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Jan 3, 2023
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly 3.2.0 for 3.2.0 version labels Jan 3, 2023
jieguangzhou
jieguangzhou previously approved these changes Jan 4, 2023
Copy link
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

23.8% 23.8% Coverage
0.0% 0.0% Duplication

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants