-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source env list in common.properties #13317
Add source env list in common.properties #13317
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #13317 +/- ##
============================================
- Coverage 39.55% 39.55% -0.01%
- Complexity 4294 4304 +10
============================================
Files 1072 1079 +7
Lines 40565 40645 +80
Branches 4656 4665 +9
============================================
+ Hits 16045 16076 +31
- Misses 22734 22780 +46
- Partials 1786 1789 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f8f140d
to
c7a1bf7
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
Since use
sudo -u
to execute a shell task, the env will not load automatically, so we need to add default env list to load in shell task.After this change, the env list will be loaded at the below order
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md