[Feature][Api] When use api to run a process we want get processInstanceId #13184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianli2022
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS,
ruanwenjun,
kezhenxu94 and
zhongjiajie
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ce/src/main/java/org/apache/dolphinscheduler/service/process/TriggerRelationServiceImpl.java
Fixed
Show fixed
Hide fixed
...ce/src/main/java/org/apache/dolphinscheduler/service/process/TriggerRelationServiceImpl.java
Fixed
Show fixed
Hide fixed
qianli2022
changed the title
qianli2022
changed the title
qianli2022
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #13184 +/- ##
=========================================
Coverage 39.55% 39.56%
- Complexity 4326 4335 +9
=========================================
Files 1084 1086 +2
Lines 40916 40969 +53
Branches 4697 4702 +5
=========================================
+ Hits 16186 16210 +24
- Misses 22927 22954 +27
- Partials 1803 1805 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caishunfeng
reviewed
Jan 6, 2023
...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TriggerRelation.java
Outdated
Show resolved
Hide resolved
...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
Outdated
Show resolved
Hide resolved
| @@ -241,4 +241,6 @@ void sendStartTask2Master(ProcessInstance processInstance, int taskId, | |||
| void forceProcessInstanceSuccessByTaskInstanceId(Integer taskInstanceId); | |||
|
|
|||
| Integer queryTestDataSourceId(Integer onlineDataSourceId); | |||
|
|
|||
| void saveCommandTrigger(Integer commandId, Integer processInstanceId); | |||
There was a problem hiding this comment.
Can we use the commandDao? And then we can put the command operation into it.
added 3 commits
January 17, 2023 09:21
caishunfeng
reviewed
Jan 17, 2023
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TriggerRelation.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TriggerRelation.java
Outdated
Show resolved
Hide resolved
...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/apache/dolphinscheduler/service/process/TriggerRelationServiceImpl.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
If this ID is obtained, the user can track the states of the task by it. processId cannot be used because multiple jobs may be triggered.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
close #12665