[improvement-#11879]Keyword Search Improvement #12951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
added
improvement
Codecov Report
@@ Coverage Diff @@
## dev #12951 +/- ##
============================================
- Coverage 39.44% 39.30% -0.15%
- Complexity 4244 4274 +30
============================================
Files 1052 1069 +17
Lines 39857 40135 +278
Branches 4586 4593 +7
============================================
+ Hits 15723 15774 +51
- Misses 22356 22581 +225
- Partials 1778 1780 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Amy0104 PTAL |
Amy0104
reviewed
Nov 24, 2022
| import { defineComponent, withKeys, PropType } from 'vue' | ||
| import { NInput } from 'naive-ui' | ||
|
|
||
| const placeholder ='Please enter keyword' |
There was a problem hiding this comment.
It needs to handle the different locales.
|
Kudos, SonarCloud Quality Gate passed!
|
shangeyao
pushed a commit
to shangeyao/dolphinscheduler
that referenced
this pull request
Dec 3, 2022
* [improvement-apache#11879]Keyword Search Improvement * [improvement] add a search component * [Feature][UI] Revise the `Search` component. * [improvement] add search components * [improvement] fix * [improvement] remove unUsed * [improvement] remove unUsed * handle the different locales. Co-authored-by: Jackie <‘[email protected]’> Co-authored-by: Amy <[email protected]>
ly109974
added a commit
to ly109974/dolphinscheduler
that referenced
this pull request
Apr 26, 2024
ly109974
pushed a commit
to ly109974/dolphinscheduler
that referenced
this pull request
Apr 26, 2024
cherry-pick [improvement-apache#11879]Keyword Search Improvement (apache#12951) See merge request DataTech/dolphinscheduler!7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
add a shortcut Key
Brief change log
add a shortcut Key
Verify this pull request
This pull request is code cleanup without any test coverage.