Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]Source skip check #12900

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

insist777
Copy link
Contributor

@insist777 insist777 commented Nov 15, 2022

Purpose of the pull request

close #12896

Brief change log

Data source creation, skip connection check when updating

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #12900 (d1b69b2) into dev (6d8befa) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12900      +/-   ##
============================================
- Coverage     39.46%   39.41%   -0.05%     
+ Complexity     4247     4240       -7     
============================================
  Files          1052     1052              
  Lines         39860    39852       -8     
  Branches       4582     4584       +2     
============================================
- Hits          15731    15708      -23     
- Misses        22349    22365      +16     
+ Partials       1780     1779       -1     
Impacted Files Coverage Δ
...eduler/api/service/impl/DataSourceServiceImpl.java 50.75% <ø> (-1.02%) ⬇️
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 51.19% <0.00%> (-1.20%) ⬇️
...duler/plugin/task/api/AbstractCommandExecutor.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@WangJPLeo WangJPLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of security, it is not allowed to link test in the API. In terms of business, it should not be deleted, but how can it be optimized to be safe.

@WangJPLeo WangJPLeo added this to the 3.2.0 milestone Nov 17, 2022
@WangJPLeo WangJPLeo added feature new feature 3.2.0 for 3.2.0 version labels Nov 17, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 528f45a into apache:dev Nov 17, 2022
@insist777 insist777 deleted the Source_skip_check branch November 23, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Datasource]It is unnecessary to check the validity when saving the data source
4 participants