-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve]Source skip check #12900
[improve]Source skip check #12900
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #12900 +/- ##
============================================
- Coverage 39.46% 39.41% -0.05%
+ Complexity 4247 4240 -7
============================================
Files 1052 1052
Lines 39860 39852 -8
Branches 4582 4584 +2
============================================
- Hits 15731 15708 -23
- Misses 22349 22365 +16
+ Partials 1780 1779 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of security, it is not allowed to link test in the API. In terms of business, it should not be deleted, but how can it be optimized to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of the pull request
close #12896
Brief change log
Data source creation, skip connection check when updating
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md