Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][alert-12865] translate alert input field tips to chinese when using chinese #12879

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

Tianqi-Dotes
Copy link
Member

@Tianqi-Dotes Tianqi-Dotes commented Nov 13, 2022

Purpose of the pull request

translate alert input field tips to chinese when using Chinese
close ##12865

Brief change log

translate alert input field tips to chinese when using chinese

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Tianqi-Dotes Tianqi-Dotes added this to the 3.1.2 milestone Nov 14, 2022
@Tianqi-Dotes Tianqi-Dotes added bug Something isn't working 3.1.x for 3.1.x version labels Nov 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #12879 (2c80a37) into dev (43d69ae) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #12879      +/-   ##
============================================
+ Coverage     39.16%   39.25%   +0.08%     
- Complexity     4212     4230      +18     
============================================
  Files          1046     1051       +5     
  Lines         39740    39824      +84     
  Branches       4578     4568      -10     
============================================
+ Hits          15563    15631      +68     
- Misses        22406    22421      +15     
- Partials       1771     1772       +1     
Impacted Files Coverage Δ
...in/alert/dingtalk/DingTalkAlertChannelFactory.java 98.79% <100.00%> (ø)
...r/plugin/alert/email/EmailAlertChannelFactory.java 98.82% <100.00%> (ø)
...plugin/alert/feishu/FeiShuAlertChannelFactory.java 97.36% <100.00%> (ø)
...ler/plugin/alert/http/HttpAlertChannelFactory.java 97.36% <100.00%> (ø)
...plugin/alert/script/ScriptAlertChannelFactory.java 95.83% <100.00%> (ø)
...r/plugin/alert/slack/SlackAlertChannelFactory.java 100.00% <100.00%> (ø)
...in/alert/telegram/TelegramAlertChannelFactory.java 100.00% <100.00%> (ø)
...lert/webexteams/WebexTeamsAlertChannelFactory.java 98.24% <100.00%> (ø)
...plugin/alert/wechat/WeChatAlertChannelFactory.java 97.82% <100.00%> (ø)
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 250d81b into apache:dev Nov 14, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.2, 3.1.3 Dec 7, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.3, 3.2.0 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants