[Feature-12526][Api] add dynamic task function: shell task #12840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Dotes
requested review from
kezhenxu94,
caishunfeng and
SbloodyS
as code owners
Tianqi-Dotes
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #12840 +/- ##
============================================
+ Coverage 39.12% 39.27% +0.14%
- Complexity 4192 4235 +43
============================================
Files 1044 1053 +9
Lines 39447 39883 +436
Branches 4530 4586 +56
============================================
+ Hits 15434 15663 +229
- Misses 22259 22445 +186
- Partials 1754 1775 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caishunfeng
changed the title
|
SonarCloud Quality Gate failed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @ResponseStatus(HttpStatus.OK) | ||
| @ApiException(LIST_TASK_TYPE_ERROR) | ||
| @AccessLogAnnotation(ignoreRequestArgs = "loginUser") | ||
| public Result listDynamicTaskTypes(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter
| @ResponseStatus(HttpStatus.OK) | ||
| @ApiException(LIST_TASK_TYPE_ERROR) | ||
| @AccessLogAnnotation(ignoreRequestArgs = "loginUser") | ||
| public Result listDynamicTaskCategories(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser) { |
Check notice
Code scanning / CodeQL
Useless parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
add dynamic task function: shell task
see #12526
Brief change log
add dynamic task function: shell task
Verify this pull request
Manually verified the change by testing locally.