[Improvement-12782][UT] Add UT for the 13 implementations of ResourceAcquisitionAndPermissionCheck #12784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #12784 +/- ##
============================================
+ Coverage 39.38% 39.44% +0.05%
+ Complexity 4272 4271 -1
============================================
Files 1067 1067
Lines 40120 40120
Branches 4605 4605
============================================
+ Hits 15801 15825 +24
+ Misses 22540 22518 -22
+ Partials 1779 1777 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -540,7 +541,7 @@ | |||
| * @param userId | |||
| * @return | |||
| */ | |||
| Set<T> listAuthorizedResource(int userId, Logger logger); | |||
| Set<T> listAuthorizedResourceIds(int userId, Logger logger); | |||
Check notice
Code scanning / CodeQL
Useless parameter
rickchengx
force-pushed
the
Improvement-12782
branch
from
4dbba33
to
46c6807
Compare
…AcquisitionAndPermissionCheck
rickchengx
force-pushed
the
Improvement-12782
branch
from
46c6807
to
d784cc6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
listAuthorizedResource()returns the resource ids rather than the resource, rename this method tolistAuthorizedResourceIds()to remove ambiguityVerify this pull request
covered by UT