[Bug][API]edit workflow query resources list error.

[hstdream]

Purpose of the pull request

close #12573

Brief change log

Verify this pull request

edit workflow

[codecov-commenter]

Codecov Report

Merging #12664 (a6af154) into dev (9e0c9af) will increase coverage by 0.01%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##                dev   #12664      +/-   ##
============================================
+ Coverage     39.04%   39.06%   +0.01%     
- Complexity     4185     4186       +1     
============================================
  Files          1043     1043              
  Lines         39511    39515       +4     
  Branches       4540     4541       +1     
============================================
+ Hits          15428    15436       +8     
+ Misses        22324    22318       -6     
- Partials       1759     1761       +2     

Impacted Files	Coverage Δ
...heduler/api/service/impl/ResourcesServiceImpl.java	37.45% <16.66%> (-0.25%)	⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java	50.80% <0.00%> (+7.25%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

37.5% Coverage
0.0% Duplication

[caishunfeng]

I found that this pr can not resolve the issue, when I want to add new shell task, it will query resources and throw error too.

I think we should change the front part, if fullName is empty, don't request resource list.

[hstdream]

I found that this pr can not resolve the issue, when I want to add new shell task, it will query resources and throw error too.

I think we should change the front part, if fullName is empty, don't request resource list.

Yours is another request, and reporting an error is not a problem with me

[caishunfeng]

I found that this pr can not resolve the issue, when I want to add new shell task, it will query resources and throw error too.
I think we should change the front part, if fullName is empty, don't request resource list.

Yours is another request, and reporting an error is not a problem with me

related pr #12076 cc @SbloodyS @EricPyZhou

[EricPyZhou]

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

[calvinjiang]

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

@hstdream @caishunfeng I think one of the most important issues is the error message. That couldn't tell users what the exact problem is. The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

[EricPyZhou]

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

@hstdream @caishunfeng I think one of the most important issues is the error message. That couldn't tell users what the exact problem is. The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

@hstdream @caishunfeng I think one of the most important issues is the error message. That couldn't tell users what the exact problem is. The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

#12901 now in this issue, we propose to return empty list when a tenant resource path is not found.

[davidzollo]

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

@hstdream @caishunfeng I think one of the most important issues is the error message. That couldn't tell users what the exact problem is. The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

+1, The error message should tell users like 'You need to set the resource storage in the file of common.properties.' is a better suggestion @hstdream what do you think?

[davidzollo]

The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

[EricPyZhou]

@hstdream please confirm two things:

1. Do you login as admin user?
2. Do all tenantCodes used by all users have its path defined in your environment? For example, if you are using S3 bucket, verify that if tenantCode/resources/ exist
   If not, then it will throw this error.

@hstdream @caishunfeng I think one of the most important issues is the error message. That couldn't tell users what the exact problem is. The error message should tell users like 'You need to set the resource storage in the file of common.properties.'

+1, The error message should tell users like 'You need to set the resource storage in the file of common.properties.' is a better suggestion @hstdream what do you think?

Please shift discussion into #12901 as it is the dedicated one for designing implementations on resolving this issue.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

[github-actions]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.