Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-12658][Permission] Improve the readability of setPerm() in grantProjectbyCode() #12660

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

setPerm(Constants.AUTHORIZE_WRITABLE_PERM) in grantProjectbyCode()

just like in grantProject() as below

截屏2022-11-02 12 01 42

Verify this pull request

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #12660 (fc4ac43) into dev (3ff328c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev   #12660   +/-   ##
=========================================
  Coverage     39.05%   39.06%           
+ Complexity     4185     4184    -1     
=========================================
  Files          1043     1043           
  Lines         39506    39506           
  Branches       4539     4543    +4     
=========================================
+ Hits          15429    15432    +3     
+ Misses        22318    22314    -4     
- Partials       1759     1760    +1     
Impacted Files Coverage Δ
...inscheduler/api/service/impl/UsersServiceImpl.java 70.49% <100.00%> (ø)
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 50.00% <0.00%> (+6.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added the improvement make more easy to user or prompt friendly label Nov 3, 2022
@caishunfeng caishunfeng added this to the 3.2.0 milestone Nov 3, 2022
@caishunfeng caishunfeng merged commit c69376e into apache:dev Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Permission] Improve the readability of setPerm() in grantProjectbyCode()
3 participants