Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-12650][Permission] Improve the check of resourcePermissionCheck() #12652

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[Improvement-12650][Permission] Improve the check of resourcePermissionCheck() #12652

merged 1 commit into from
Nov 3, 2022

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

Use containsAll() rather than removeAll() and Collections.isNotEmpty() to check the resource Permission.

Verify this pull request

ruanwenjun
ruanwenjun approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

caishunfeng
caishunfeng approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng added the improvement make more easy to user or prompt friendly label Nov 3, 2022
@caishunfeng caishunfeng added this to the 3.2.0 milestone Nov 3, 2022
@caishunfeng caishunfeng merged commit 44e0935 into apache:dev Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng caishunfeng approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@rickchengx rickchengx

Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Permission] Improve the check of resourcePermissionCheck()
3 participants
@rickchengx @caishunfeng @ruanwenjun