-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][BatchQuery] Batch query ProcessDefinitions belongs to need failover ProcessInstance. #12506
Conversation
...dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI pass.
Oops. I run ./mvnw spotless:check locally ,and there doesn't have violations...And after run ./.mvnw spotless:apply ,there has nothing changed.....How could i fix this...Any idea? |
。。。 |
I approve to run the CI (Due to you are the first contributor) and will check it after the CI finish. |
Codecov Report
@@ Coverage Diff @@
## dev #12506 +/- ##
============================================
- Coverage 39.05% 39.03% -0.03%
+ Complexity 4186 4183 -3
============================================
Files 1043 1043
Lines 39506 39490 -16
Branches 4544 4526 -18
============================================
- Hits 15430 15413 -17
Misses 22319 22319
- Partials 1757 1758 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SonarCloud reported that |
Let me remove |
I had approved to run CI (due to first time contributor ) |
@BongBongBang please use spotless to format code style. |
Actually, I do did that maven command before submission because of the failure about |
Like chinese idiom, 好事多磨 |
You can set the pre-commit (see the doc above), and then it will auto spotless every commit. |
…need failover ProcessInstance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI pass
SonarCloud Quality Gate failed. |
Hi @BongBongBang , thanks for your contribution and welcome to join community 🎉 . Looking forward to your next contribution. |
Purpose of the pull request
Brief change log
[Improvement][BatchQuery] Batch query ProcessDefinitions belongs to need failover ProcessInstance.
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).