[Refactor] Migrate all workergroup-related interface functions from ProcessServiceImpl #12493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkAssassinator
requested review from
caishunfeng and
SbloodyS
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #12493 +/- ##
============================================
+ Coverage 39.63% 39.75% +0.11%
- Complexity 4196 4209 +13
============================================
Files 1038 1038
Lines 38852 38854 +2
Branches 4450 4452 +2
============================================
+ Hits 15400 15445 +45
+ Misses 21712 21675 -37
+ Partials 1740 1734 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ruanwenjun Please help to review this PR. thx. |
caishunfeng
previously approved these changes
Oct 25, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
DarkAssassinator
force-pushed
the
dev_yann_refactor_issue#12470
branch
from
41c0c27
to
5999485
Compare
DarkAssassinator
requested review from
caishunfeng
and removed request for
SbloodyS
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This change added tests